Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add conmon-rs process ID and host name to tracing output #792

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Oct 11, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows tracing multiple conmon-rs instances selectively by their PID and host.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Added `process.pid` and `host.name` to Open Telemetry traces.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert saschagrunert changed the title Add conmon-rs process ID to tracing output Add conmon-rs process ID and host name to tracing output Oct 11, 2022
Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@rphillips
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 11, 2022
@openshift-merge-robot openshift-merge-robot merged commit 7fe60f6 into containers:main Oct 11, 2022
@saschagrunert saschagrunert deleted the tracing-pid branch October 11, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants